Re: [PATCH] hamradio driver fixes

From: Bernard Pidoux (mtrk@roskapostia.tunk.net)
Date: Tue Jan 20 2004 - 01:33:25 EET

  • Next message: Jeroen Vreeken: "Re: [PATCH] hamradio driver fixes"

    Hi,

    Thanks and congratuations Jeroen.
    I applied the patch and it cured the problems of kernel panic when
    removing mkiss module driver after performing a kissattach.

    Just for your information, there was two warnings during scc.c
    compilation :
    line 1201 and 1279 warning comparison is always true due to limited
    range of data type.

    I am using ax25, mkiss, rose and netrom drivers.

    There is still a similar problem left when removing rose module driver
    after and only after attaching a rose port with rsattach.

    I give the Call Trace :
    free_module + 0x44/0x90
    sys_delete_module + 0x133/0x1a0
    do_munmap + 0xfs/0x150
    sys_munmap + 0x34/0x60
    syscall_call °0x7/0xb

    Hope this will help.

    73 de Bernard, F6BVP

    -------------------

    Jeroen Vreeken wrote:
    > Hi,
    >
    > This is a patch that fixes some problems in the hamradio drivers in 2.6.1
    > Part is a resent that was probably lost during the holiday season.
    > The fixes include:
    >
    > + scc.c usage of rtnl lock and register_netdev.
    > + scc.c properly initialize timers.
    > + remove cli() call in 6pack.c (The line of code that was 'protected'
    > couldn't have needed it anyway)
    > + fix init of reused devices and remove cli()
    >
    > The only thing remaining is a call to cli() in the dmascc driver, I don't
    > know what exactly it aims to protect....
    >
    > Jeroen

    -
    To unsubscribe from this list: send the line "unsubscribe linux-hams" in
    the body of a message to lysbzyq.kgkqulpvs@mail.dy.fi
    More majordomo info at http://vger.kernel.org/majordomo-info.html

    This archive was generated by hypermail 2b30 : Tue Jan 20 2004 - 00:34:01 EET