Re: [PATCH] ax25 & netrom fixes for 2.6

From: David S. Miller (gefcxhes@mx.dy.fi)
Date: Wed Aug 13 2003 - 13:10:38 EEST

  • Next message: David S. Miller: "Re: [PATCH] Convert ax25 to seq_file"

    On Tue, 12 Aug 2003 23:09:51 +0200
    Jeroen Vreeken <nuojf.jdetrn@roskapostia.tunk.net> wrote:

    > Since at the moment the only zero-copy path I can imagine is from packets
    > over a bpq ethernet device wouldn't it be the easiest to just check at
    > ax25_rcv() for non-linear packets and call skb_linearize() for them?

    skb_linearize() is a deprecated interface, no new pieces of
    code should use it. If you want to mark the protocol as a new
    one you must do the non-linear handling properly just like every
    other protocol.

    Please, if you're going to be working in this area, fix this up properly
    and don't paper around the problems Stephen is showing to you.
    -
    To unsubscribe from this list: send the line "unsubscribe linux-hams" in
    the body of a message to terhi.victor@logonet.com
    More majordomo info at http://vger.kernel.org/majordomo-info.html

    This archive was generated by hypermail 2b30 : Wed Aug 13 2003 - 13:17:21 EEST