Re: [PATCH] ax25_cb refcounting & waitqueue usage

From: Jeroen Vreeken (cezcj@skekraft.net)
Date: Wed Jul 09 2003 - 01:52:15 EEST

  • Next message: Ronald Jochems: "Request change ???"

    On 2003.07.07 19:25:04 +0200 Arnaldo Carvalho de Melo wrote:

    > so may I suggest that you use the same arquitecture of list handling in
    > struct
    > sock? i.e. use hlist and have a ax25_cb_add, ax25_cb_del{_init} that does
    > the
    > refcounting, etc, so that it "looks like" what we have for struct sock
    > and that
    > way a casual ax25 hacker can take advantage of what he learnt from
    > studying
    > struct sock handling? I plan to attack the list searching problem in a
    > general
    > way, i.e. abstracting more the search in a bsearch(3) way, using inlines
    > and
    > macros so that all the protocols have a more consistent implementation.

    Good idea...

    I now have the first ax25 stack with hlists running on my test system...
    It needs some cleaning up (some old junk commented out at the moment and I
    need to rename some functions to be more descriptive) which will probably
    happen in the next few days.
    I also removed the bpq header length stuff in the skb allocation, it now
    uses the hard_header_length of the network device... The stack should not
    have to now which devices there might possibly be.

    Jeroen

    -
    To unsubscribe from this list: send the line "unsubscribe linux-hams" in
    the body of a message to terhi.victor@logonet.com
    More majordomo info at http://vger.kernel.org/majordomo-info.html



    This archive was generated by hypermail 2b30 : Wed Jul 09 2003 - 01:48:13 EEST