Re: [PATCH] ax25_cb refcounting & waitqueue usage

From: Arnaldo Carvalho de Melo (lvgepm@cypresscom.net)
Date: Mon Jul 07 2003 - 16:37:10 EEST

  • Next message: Arno Verhoeven: "Re: Split screen telnet client?"

    Em Sun, Jul 06, 2003 at 07:27:34PM +0200, Jeroen Vreeken escreveu:
    > Hi,
    >
    > Second patch for this weekend...
    > This patch does two things, it adds reference counting to the ax25_cb
    > structure (until now only the ax25_cb list was protected, not the parts
    > using it) and it fixes an oops on interrupted socket syscalls. (e.g.
    > pressing Ctrl-C while in the connect function) The waitqueue was not
    > removed from the list and caused an oops in the socket release.
    >
    > I have had only a quick look at Steven's patch but I don't think the two
    > will clash...

    Hey, why not use sk->refcnt by means of sock_hold/sock_put? Current sources
    even do that implicitely when you do a sk_add_node (sock_hold) and a
    sk_del_node{_init} (sock_put)... Now it is just a matter of doing a sock_hold
    when searching in some list and then dropping the refcnt when done using the
    sock returned by the search function.

    - Arnaldo
    -
    To unsubscribe from this list: send the line "unsubscribe linux-hams" in
    the body of a message to nunkn.tyiehi@grocerybiz.com
    More majordomo info at http://vger.kernel.org/majordomo-info.html



    This archive was generated by hypermail 2b30 : Mon Jul 07 2003 - 16:37:20 EEST