Re: [PATCH] C99 initializers for net/netrom/sysctl_net_netrom.c

• Previous message: Art Haas: "[PATCH] C99 initializers for net/rose/sysctl_net_rose.c"
• In reply to: Art Haas: "[PATCH] C99 initializers for net/netrom/sysctl_net_netrom.c"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Em Thu, Feb 13, 2003 at 07:23:20PM -0600, Art Haas escreveu:
> Hi.
>
> Here's a patch that switches the file to use C99 initiailzers to aid
> readability and remove warings if '-W' is used.
>
> + .extra1 = &min_quality,
> + .extra2 = &max_quality

Art, just a small nitpick: the "standard" in the kernel sources is for all
the members to have an ending comma, just like this:

> + .extra1 = &min_quality,
> + .extra2 = &max_quality,
                                              ^
                                              ^
                                              ^
So that when we need to add another member the patch gets smaller 8)

Aside from this small nitpick, keep it up the good work!

- Arnaldo
-
To unsubscribe from this list: send the line "unsubscribe linux-hams" in
the body of a message to nkmubnps@kdnet.com
More majordomo info at http://vger.kernel.org/majordomo-info.html

• Next message: James Cutler: "Kissattach and pseudoterminals"
• Previous message: Art Haas: "[PATCH] C99 initializers for net/rose/sysctl_net_rose.c"
• In reply to: Art Haas: "[PATCH] C99 initializers for net/netrom/sysctl_net_netrom.c"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b30 : Fri Feb 14 2003 - 04:18:15 EET