Re: ax25 kernel problem sometimes accur

From: M Taylor (nyjoqguy.wchim@vrt.be)
Date: Thu Dec 05 2002 - 03:16:41 EET

  • Next message: Tihomir Heidelberg: "Re: ax25 kernel problem sometimes accur"

    On Wed, Dec 04, 2002 at 09:20:09PM +0100, Tihomir Heidelberg wrote:
    >
    > so, the ax25_free_sock function should look:
    > static void ax25_free_sock(struct sock *sk)
    > {
    > ax25_free_cb(sk->protinfo.ax25);
    > sk->protinfo.ax25->sk=NULL;
    > }
    >
    > of course, then you should do make modules;make modules_install
    > if you use ax25 in module or make install if you have it compiled
    > in kernel.
    >
    > this should not do anything harmfull in kernel, I am quite sure :)

    Well, it could crash your system. sk->protinfo.ax25 is kfree'ed in
    the line before it, so you are accessing invalid data...

    Your suggestion wants to be equalivent to sk = NULL;,
    so you should at least change it to use a valid statement.
    Though I wonder if you meant sk->protinfo.ax25 = NULL;

    Best Regards,
     ve1mct
    -
    To unsubscribe from this list: send the line "unsubscribe linux-hams" in
    the body of a message to whrebavb.cvzxpa@allieddata.com
    More majordomo info at http://vger.kernel.org/majordomo-info.html

    This archive was generated by hypermail 2b30 : Thu Dec 05 2002 - 03:23:26 EET