From: Ralf Baechle DO1GRB (vojalttp@relia.net)
Date: Fri Oct 11 2002 - 18:38:50 EEST
On Fri, Oct 11, 2002 at 03:56:23PM +0100, Steven Whitehouse wrote:
> > Another problem we still have - and we're sharing it with other protocols
> > such ipv4 - is that our proc code is holding a lock for the time the
> > /proc file is open. That's not a significant time but it may delay
> > access, so I've made most of those loads rw locks. Worst case a buggy
> > or malicious piece of software might even hold a proc file open for a long
> > time thereby stalling the functioning of the stack partially or fully.
> >
> Its only during read operations, not the open that the lock is held I
> think, but I agree that an rw lock is the best solution here.
The only solution I see would be redoing the data structures or as
implemented in a few other places in the kernel accepting O(n) behaviour
for the seq_operations.next method - which would make reading the
performance for reading the proc file O(n^2). But that's a minor
problem at the moment.
73 de DO1GRB op Ralf
-- Loc. JN47BS / CQ 14 / ITU 28 / DOK A21 - To unsubscribe from this list: send the line "unsubscribe linux-hams" in the body of a message to uyau.iizuzjsl@steinberg.de More majordomo info at http://vger.kernel.org/majordomo-info.html
This archive was generated by hypermail 2b30 : Fri Oct 11 2002 - 18:39:18 EEST