Re: AX25/socket kernel PATCHes

From: Jeroen Vreeken (vijbl.xjwk@mail.dy.fi)
Date: Sat Dec 29 2001 - 01:15:11 EET

  • Next message: Keith Owens: "Re: link error in SCC driver"

    On 2001.12.29 00:09:43 +0100 Alan Cox wrote:
    > > I just downloaded the latest 2.4.17 kernel and I still do not see the
    > > patches of Jeroen Vreeken, PE1RXQ, applied. Anybody know the reason
    > why?
    >
    > Because it changes core code in a way that shouldn't be needed
    >
    > > * Arnaldo C. Melo : cleanups, use
    > skb_queue_purge
    > > + * Jeroen Vreeken : Add check for
    > sk->dead in sock_def_write_space
    > > *
    > > * To Fix:
    > > *
    > > @@ -1146,7 +1147,7 @@
    > > /* Do not wake up a writer until he can make "significant"
    > > * progress. --DaveM
    > > */
    > > - if((atomic_read(&sk->wmem_alloc) << 1) <= sk->sndbuf) {
    > > + if(!sk->dead && (atomic_read(&sk->wmem_alloc) << 1) <=
    > sk->sndbuf) {
    > > if (sk->sleep && waitqueue_active(sk->sleep))
    > > wake_up_interruptible(sk->sleep);
    >
    > Does the fix work without this change ?

    The simple fix, no...

    However I have started to make a patch for ax25 to use sock_orphan, but
    recently we had some trouble with 2.4 kernels that might be related to my
    changes or the scc driver, so I am now looking at fixing that, as soon as
    that is sorted out I will submit a patch that fixes it the right way.

    Jeroen

    -
    To unsubscribe from this list: send the line "unsubscribe linux-hams" in
    the body of a message to qjkqsr@centix.net
    More majordomo info at http://vger.kernel.org/majordomo-info.html



    This archive was generated by hypermail 2b30 : Sat Dec 29 2001 - 01:14:41 EET