Re: [linux-fbdev] gcc -W for 2.2.17-pre14

• Previous message: Arno Verhoeven: "Connection 2 voice repeaters via packet radio link?"
• In reply to: Andrew Morton: "gcc -W for 2.2.17-pre14"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Tue, 1 Aug 2000, Andrew Morton wrote:
> drivers/video/fbmem.c:478
>
> if (con2fb.console < 0 || con2fb.console > MAX_NR_CONSOLES)
> return -EINVAL;
>
> I think this is an off-by-one. Should it be `>= MAX_NR_CONSOLES'?

No, see the code below.
0 means `set them all', 1--MAX_NR_CONSOLES means `set VC i'.

Gr{oetje,eeting}s,

                                                Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- kiwkt@mailit.tunk.net
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds

• Next message: Ron Jochems: "Re: Connection 2 voice repeaters via packet radio link?"
• Previous message: Arno Verhoeven: "Connection 2 voice repeaters via packet radio link?"
• In reply to: Andrew Morton: "gcc -W for 2.2.17-pre14"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Wed Aug 02 2000 - 22:59:59 EEST