Linux-Hams archive - February 1997: Re: Setting parameters

Re: Setting parameters

Jonathan Naylor (etyfkp@roskapostia.tunk.net)
Fri, 7 Feb 1997 08:53:44 +0000 (GMT)


Hello Joerg

On Thu, 6 Feb 1997, Joerg Reuter wrote:
> > I do intend to do some tweaking of this interface in the future to make
> > (for example) /proc/sys/net/ax25/ax1.parms 11th parameter into
> > /proc/sys/net/ax25/ax1/idle_timeout or something similar, and so on.=20
>
> Remember me suggesting this? And remember that I wrote that it
> would be unlikely that I would do it? Well, never say never... ;-)

I had thought about it from time to time since but never done anything
towards it.

> The attached patch is not very well tested yet (kernel 2.1.25

Thats what users are for :-)

> I removed AX25_VALUES_TEXT and included it in CONNECT_MODE:
>
> 0 - no connects allowed
> 1 - connects allowed, ignore I frames with textmode PID
> 2 - connects allowed, allow I frames with textmode PID (default)
>
> On the other hand: do we really need this? If we do not have any listener
> set up for incoming AX.25 calls we discard PID F0 anyway.

I'm not sure we do need it to be honest. I will integrate it into
ax25-module-11 and the next 2.1.x too. I will change some of the names if
you don't mind, but not seriously different.

> The only other change is that the AX25_VALUES_* and the AX25_STATE_*
> #defines are "enums" now.

Fair enough. I'll probably go through other protocols and do a similar
clean up.

> The patch is attached below, for the sake of non-MIME-capable readers
> UUcoded...
>
> 73 de J=F6rg

This patch is very much appreciated.

Jonathan

--
+----------------------------------+---------------------------------------+
| e-mail: uepydtfk@picsearch.com        | Telephone: +44 (0) 973 695261         |
+----------------------------------+---------------------------------------+
|           Author of Linux kernel AX.25, NET/ROM and Rose.                |
+--------------------------------------------------------------------------+